-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(require): bind multiple events with single common handler #11
Merged
XavierBoubert
merged 3 commits into
CodeCorico:master
from
frostbane:feature/multiple-events
Jun 20, 2016
Merged
feat(require): bind multiple events with single common handler #11
XavierBoubert
merged 3 commits into
CodeCorico:master
from
frostbane:feature/multiple-events
Jun 20, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks again @frostbane! Please can you follow the coding style? name.split('-').forEach(function(eventName) {
if (eventName.trim()) {
events[eventName] = attr.value;
}
}); |
I have updated the documentation with your work 😉 |
I have refactored the code. |
Sorry sorry but a if, even in single ligne needs its brackets. 😅 if (eventName.trim()) {
events[eventName] = attr.value;
} |
(I prefer to let you correct that to add commits after your work 😉) |
(And strings are always in More on the JSCS rules |
Perfect! |
Released in 0.6.4 |
0.6.5 in fact. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was browsing through the Ractive documentation and saw
and I thought that
data-on-childevent1-childevent2-....="parentevent" <!-- when any of the childeventN is fired parentevent will get fired -->
data-listen-childevent1-childevent2-...="parentevent" <!-- when parentevent is fired all of the childeventNs will also get fired -->
could also be possible.
Here's a sample on how I use it: