Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Naming convention for .conf-file #1

Closed
Grub4K opened this issue Feb 10, 2021 · 1 comment
Closed

Naming convention for .conf-file #1

Grub4K opened this issue Feb 10, 2021 · 1 comment

Comments

@Grub4K
Copy link
Contributor

Grub4K commented Feb 10, 2021

Naming the configuration file sub_select.conf breaks with the other two filenames and is confusing at first.
I would suggest changing it to opt.read_options(o, "sub-select") in the main script to keep the naming consistent or change the two other files to sub_select too.

@CogentRedTester
Copy link
Owner

Calling it sub_select is to conform to the standard naming conventions of other mpv scripts. The default name for the config file of a script is the filename with characters like hyphens substututed for _.

I also don't want to change the script name to use underlines because it would break the naming conventions of my other scripts.

Perhaps the Json file should have used underlines as well, but now that I'm using similar naming schemes for the json files in my other scripts, I also don't really want you chance it.

Unless you can justify making a breaking change for several scripts I'll be leaving things as they are.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants