Skip to content
This repository has been archived by the owner on Aug 6, 2018. It is now read-only.

Inconsistent usage of _default_config and default_config in config.py #32

Open
robozman opened this issue May 22, 2018 · 1 comment
Open

Inconsistent usage of _default_config and default_config in config.py #32

robozman opened this issue May 22, 2018 · 1 comment
Labels
bug
Milestone
Windows Support

Comments

@robozman
Copy link
Member

In config.py we declare default_config = path.join(_config_folder, 'config.yaml' and then proceed to use cls._default_config everywhere else. I've encountered this issue while porting to Windows. Is this just a typo or does it work on Linux for some reason. @jhgarner, @sumnerevans
@robozman robozman added the bug label May 22, 2018
@robozman robozman changed the title Inconsistend Usage of _default_config and default_config in config.py Inconsistent Usage of _default_config and default_config in config.py May 22, 2018
@robozman robozman changed the title Inconsistent Usage of _default_config and default_config in config.py Inconsistent usage of _default_config and default_config in config.py May 22, 2018
@robozman robozman added this to the Windows Support milestone May 22, 2018
@robozman robozman mentioned this issue May 22, 2018
Open
@sumnerevans
Copy link
Member

sumnerevans commented May 22, 2018 •
edited
Loading

All instances of _default_config should be default_config. The default_config member is public (it is used in __main__:52), but it also is used in config.py:92,93,95.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Windows Support
Development

No branches or pull requests
2 participants
@robozman @sumnerevans