Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add list of not mutated methods to verbose output #59

Open
baccatabob opened this issue Apr 7, 2019 · 4 comments
Open

Add list of not mutated methods to verbose output #59

baccatabob opened this issue Apr 7, 2019 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@baccatabob
Copy link

If a method is OK for test coverage but has no contents that can be mutated, it is silently omitted from all output, even verbose. Having a list of methods (and possibly properties) that couldn't be mutated would help users not have a false sense of security / nasty surprises when they discover that mutation isn't checking everything they thought it was.

@oliwennell
Copy link
Contributor

oliwennell commented Apr 7, 2019

Yes I agree there's a potential for a false sense of security, thanks for raising @baccatabob .

Currently in verbose mode you'll get something like this when Fettle starts mutating:

Found file: MyClass.cs
   Found member MyClass.MyMethod

Would a solution be to add skipped members inline, so the output becomes more like this?

Found file: MyClass.cs
   Found member MyClass.MyMethod
      ...
   Skipped member MyClass.MyUnmutateableMethod
   Skipped member MyClass.MyUnmutateableProperty

@baccatabob
Copy link
Author

That would be good - thanks. I don't know if it needs to be more prominent, including in the default output, but this seems to be a good implementation to start with at least.

@oliwennell
Copy link
Contributor

👍

@oliwennell oliwennell added the enhancement New feature or request label Apr 7, 2019
@oliwennell oliwennell added this to the v0.5.1 milestone Apr 7, 2019
@oliwennell
Copy link
Contributor

oliwennell commented Apr 17, 2019

Looking at the code a bit more deeply, this is actually going to be harder than I thought 😅
To avoid delaying other tickets being released I'll push this back to the one after (0.5.2).

@oliwennell oliwennell modified the milestones: v0.5.1, v0.5.2 Apr 17, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants