Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Suggestion to handle 0 batch size in BatchVerifyMultiPoints #355

Closed
kevaundray opened this issue Mar 10, 2023 · 0 comments
Closed

Suggestion to handle 0 batch size in BatchVerifyMultiPoints #355

kevaundray opened this issue Mar 10, 2023 · 0 comments
Assignees
Labels
bug Something isn't working consolidate strengthen an existing feature

Comments

@kevaundray
Copy link

Observation

The function BatchVerifyMultiPoints assumes that the batch will be greater than 0. If a caller passes in an empty batch, then this line will panic.

Suggestion

Since its a public function it may be reasonable to handle the zero edge case or possibly a comment specifying that the batch is assumed to be more than zero, and the caller needs to check this before calling BatchVerifyMultiPoints.

@yelhousni yelhousni added bug Something isn't working consolidate strengthen an existing feature labels Apr 5, 2023
@gbotrel gbotrel closed this as completed Apr 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working consolidate strengthen an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants