-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(modexp-data): implement MODEXP_DATA module #547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delehef
suggested changes
Jan 18, 2024
...zation/src/main/java/net/consensys/linea/zktracer/module/modexpdata/ModexpDataOperation.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/opcode/OpCode.java
Outdated
Show resolved
Hide resolved
letypequividelespoubelles
previously requested changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add the lisp files too (constraints and columns)
arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
Outdated
Show resolved
Hide resolved
...rc/main/java/net/consensys/linea/zktracer/module/limits/precompiles/ModexpEffectiveCall.java
Show resolved
Hide resolved
...zation/src/main/java/net/consensys/linea/zktracer/module/modexpdata/ModexpDataOperation.java
Outdated
Show resolved
Hide resolved
1d3929c
to
4510b67
Compare
delehef
suggested changes
Jan 22, 2024
arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
Outdated
Show resolved
Hide resolved
...zation/src/main/java/net/consensys/linea/zktracer/module/modexpdata/ModexpDataOperation.java
Show resolved
Hide resolved
...zation/src/main/java/net/consensys/linea/zktracer/module/modexpdata/ModexpDataOperation.java
Outdated
Show resolved
Hide resolved
4510b67
to
03ce3f3
Compare
delehef
approved these changes
Jan 22, 2024
04d6056
to
f41a8bd
Compare
powerslider
added a commit
that referenced
this pull request
Jan 23, 2024
Resolves: #288 Signed-off-by: Tsvetan Dimitrov <tsvetan.dimitrov@consensys.net>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #288
Signed-off-by: Tsvetan Dimitrov tsvetan.dimitrov@consensys.net