Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: update Tracer.java for hub #1036

Closed
DavePearce opened this issue Aug 29, 2024 · 1 comment · Fixed by #1037
Closed

feat: update Tracer.java for hub #1036

DavePearce opened this issue Aug 29, 2024 · 1 comment · Fixed by #1037
Labels
bug Something isn't working

Comments

@DavePearce
Copy link
Collaborator

The aim here is to resolve the issue with the column RELATIVE_BLOCK_NUMBER which is not currently being written into the lt trace files.

@DavePearce DavePearce added the bug Something isn't working label Aug 29, 2024
@DavePearce DavePearce linked a pull request Aug 29, 2024 that will close this issue
@DavePearce
Copy link
Collaborator Author

Currently in hub/fragment/common/CommonFragment.java we have this:

public Trace trace(Trace trace) {
    final CallFrame frame = commonFragmentValues.callFrame;
    final TransactionProcessingMetadata tx = commonFragmentValues.txMetadata;
    final boolean isExec = commonFragmentValues.hubProcessingPhase == TX_EXEC;
    return trace
        .absoluteTransactionNumber(tx.getAbsoluteTransactionNumber())
        .batchNumber(tx.getRelativeBlockNumber())
        ...

After regenerating the Trace.java the batchNumber has disappeared. However, I do see .relativeBlockNumber() which looks like a sensible replacement?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant