Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Simple Fix for Problematic Replays #1307

Closed
DavePearce opened this issue Sep 25, 2024 · 0 comments · Fixed by #1308
Closed

Simple Fix for Problematic Replays #1307

DavePearce opened this issue Sep 25, 2024 · 0 comments · Fixed by #1308
Assignees
Labels

Comments

@DavePearce
Copy link
Collaborator

(see also #1289 and #1292)

So, at this stage, some replay tests are failing result checking because the replay files themselves have not yet been recaptured. However, there is a simple fix which we could use in the interim. Specifically, during world initialisation, we simple drop any StorageSnapshot which assigns 0x0 to a location.

@DavePearce DavePearce self-assigned this Sep 25, 2024
@DavePearce DavePearce linked a pull request Sep 25, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant