Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unchecked return value not flagged #1840

Closed
gsalzer opened this issue Feb 29, 2024 · 0 comments · Fixed by #1848
Closed

Unchecked return value not flagged #1840

gsalzer opened this issue Feb 29, 2024 · 0 comments · Fixed by #1848

Comments

@gsalzer
Copy link
Contributor

gsalzer commented Feb 29, 2024

Description

Mythril does not detect an unchecked call return value.

How to Reproduce

$ cat ucrv.sol
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.0;
contract ucrv {
  function send(address payable a) public {
    a.send(1);
  }
}
$ ./myth version # repo cloned, pip install -r requirements
Mythril version v0.24.5
$ ./myth analyze ucrv.sol
The analysis was completed successfully. No issues were detected.

Expected behavior

Mythril reports an unchecked return value.

Environment

  • Mythril version: 0.24.5
  • Python version: 3.10.12
  • OS and Version: GNU/Linux 6.5.0-21 Ubuntu 22.04.1 x86_64

Additional Environment or Context

The call to the solver in mythril/analysis/module/modules/unchecked_retval.py, line 87 seems to throw UnsatError, which I wouldn't have expected.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants