From 68b52fe29189b169f2b0857023e25d2004c3cff8 Mon Sep 17 00:00:00 2001 From: Griffin Yourick Date: Wed, 5 Jun 2024 15:48:22 -0400 Subject: [PATCH 1/4] test a few changes --- .github/workflows/release.yml | 12 ++++-------- .github/workflows/test.yml | 10 ++++------ 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e4a6f62..bbdba70 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,13 +34,12 @@ jobs: - name: Set up node uses: actions/setup-node@v3 with: - node-version: 16 - architecture: x64 + node-version: lts/* + - name: Update npm + run: npm install -g npm@10 # new versions of python don't include distutils. setuptools provides it. - name: Install setuptools run: pip install setuptools - - name: Update npm - run: npm install -g npm@8 - name: Install run: npm ci --ignore-scripts - name: Build @@ -64,11 +63,8 @@ jobs: with: node-version: lts/* registry-url: https://registry.npmjs.org - # new versions of python don't include distutils. setuptools provides it. - - name: Install setuptools - run: pip install setuptools - name: Update npm - run: npm install -g npm@8 + run: npm install -g npm@10 - name: Install run: npm ci --ignore-scripts - name: Download artifacts diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7f3f929..758806d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -33,14 +33,12 @@ jobs: uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - architecture: x64 - - name: Python version - run: python --version + - name: Update npm + run: npm install -g npm@10 + # new versions of python don't include distutils. setuptools provides it. - name: Install setuptools run: pip install setuptools - - name: Install dependencies + - name: Install dependencies and build run: npm ci - - name: Show node-gyp version - run: npm ls node-gyp - name: Test run: npm test From e1a65477039fb284ea624faef944c2de28c712d6 Mon Sep 17 00:00:00 2001 From: Griffin Yourick Date: Wed, 5 Jun 2024 15:50:58 -0400 Subject: [PATCH 2/4] npm should be lowercase --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bbdba70..1426a37 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -52,7 +52,7 @@ jobs: path: prebuilds/ release: needs: build - name: Release to NPM + name: Release to npm runs-on: ubuntu-latest timeout-minutes: 5 steps: From 76e7569671be1dd872121a3dadc83113d397b67c Mon Sep 17 00:00:00 2001 From: Griffin Yourick Date: Wed, 5 Jun 2024 15:52:48 -0400 Subject: [PATCH 3/4] fix npm --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 758806d..c7a06c6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -34,7 +34,7 @@ jobs: with: node-version: ${{ matrix.node }} - name: Update npm - run: npm install -g npm@10 + run: npm install -g npm@9 # npm 10 does not support node 16 # new versions of python don't include distutils. setuptools provides it. - name: Install setuptools run: pip install setuptools From f06936ef97e72d2c9fbd0cae9583b8cb92d97d45 Mon Sep 17 00:00:00 2001 From: Griffin Yourick Date: Wed, 5 Jun 2024 16:07:09 -0400 Subject: [PATCH 4/4] update actions --- .github/workflows/release.yml | 17 +++++++++-------- .github/workflows/test.yml | 4 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1426a37..c38296e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,9 +30,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Set up node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: lts/* - name: Update npm @@ -46,9 +46,9 @@ jobs: run: npm run build:${{ matrix.build-group }} shell: bash - name: Upload artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: prebuilds + name: prebuilds-${{ matrix.build-group }} path: prebuilds/ release: needs: build @@ -57,9 +57,9 @@ jobs: timeout-minutes: 5 steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Set up node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: lts/* registry-url: https://registry.npmjs.org @@ -68,10 +68,11 @@ jobs: - name: Install run: npm ci --ignore-scripts - name: Download artifacts - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: - name: prebuilds + pattern: prebuilds-* path: prebuilds/ + merge-multiple: true - name: Publish to npm run: npm publish env: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c7a06c6..0902804 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -28,9 +28,9 @@ jobs: timeout-minutes: 10 steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Set up node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} - name: Update npm