Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change to CANONICAL_LENGTH in std/testing/mock.rs #1529

Closed
LeTurt333 opened this issue Dec 5, 2022 · 0 comments · Fixed by #1541
Closed

Change to CANONICAL_LENGTH in std/testing/mock.rs #1529

LeTurt333 opened this issue Dec 5, 2022 · 0 comments · Fixed by #1541
Milestone

Comments

@LeTurt333
Copy link

Carried over from Discord

// cosmwasm-std/src/testing/mock.rs | line 81
const CANONICAL_LENGTH: usize = 54;

causes issues in tests when a human readable contract address is passed to addr_validate in the contracts core logic


Example with Juno addresses:

usize of a human readable Juno wallet address = 43 ✅

usize of a human readable Juno contract address = 63 ❌


Increasing this to something that supports contract addresses makes sense, perhaps 100 to support chains with longer prefixes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants