Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid generic parameter in CosmosMsg<C> #2249

Open
chipshort opened this issue Sep 10, 2024 · 0 comments
Open

Avoid generic parameter in CosmosMsg<C> #2249

chipshort opened this issue Sep 10, 2024 · 0 comments
Labels
Breaking (contracts) Compile-time breaking contracts
Milestone

Comments

@chipshort
Copy link
Collaborator

We still need to support the custom message feature, but having this as a generic is quite annoying for users because it has to be carried through the whole code.

In our meeting, switching to dynamic dispatch with erased_serde / typetag was proposed.

We should make sure that downstream users are not affected by the fact that this makes CosmosMsg no longer Send + Sync and that the custom message type is not necessarily Sized anymore.
This could probably be looked at for something like MultiTest.

@chipshort chipshort added the Breaking (contracts) Compile-time breaking contracts label Sep 10, 2024
@chipshort chipshort added this to the 3.0.0 milestone Sep 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Breaking (contracts) Compile-time breaking contracts
Projects
None yet
Development

No branches or pull requests

1 participant