Skip to content

Don't use the deprecated gov style #1264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
faddat opened this issue Mar 15, 2023 · 1 comment
Closed

Don't use the deprecated gov style #1264

faddat opened this issue Mar 15, 2023 · 1 comment

Comments

@faddat
Copy link
Contributor

faddat commented Mar 15, 2023 •
edited
Loading

Currently in .golangci.yml we exclude issues with staticcheck that contain simtypes because we're still converting governance types from the 45 style.

We'd want to:

  1. use only the 47 gov message style
  2. remove the exclusion of simtypes in .golangci.yml
  • TODO: fix the use of deprecated gov style, that'll remove the exclusion of "simtypes" in .golangci.yml

There's also a viable #wontfix option here, I reckon.
@faddat
Copy link
Contributor Author

faddat commented Mar 15, 2023

closing in favor of #1246 and moving in notes about .golangci.yml

@faddat faddat closed this as completed Mar 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faddat