Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade keyring / go-keychain dependencies #957

Closed
alpe opened this issue Aug 24, 2022 · 3 comments · Fixed by #985
Closed

Upgrade keyring / go-keychain dependencies #957

alpe opened this issue Aug 24, 2022 · 3 comments · Fixed by #985
Assignees
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Aug 24, 2022

We were following the SDK on the keyring + go-keychain dependencies. There had been odd compiler warnings for some time already but now it seems that people have real issues with the versions.
See #950 and linked issue for context.

in our go.mod

github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d // indirect
replace(
// Use the cosmos-flavored keyring library
github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76

I did some a quick research what other versions are used. See below.

go-keychain

github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 gaia-main, osmosis v11, sdk main, #950

github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d terra v2, juno v9, sdk v0.45.7, stargaze v6

keyring

github.com/cosmos/keyring v1.2.0 sdk main
github.com/99designs/keyring v1.2.1 gaia main, osmosis v11

github.com/99designs/keyring v1.1.6 juno v9, terra v2.1

github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76 stargaze , sdk v0.45.7
github.com/99designs/keyring v1.1.6

Next

Before upgrading the dependencies, I would love to hear some feedback from the community. Any pros or cons to follow Osmosis versions would be great!

@jhernandezb
Copy link
Contributor

The recent github.com/cosmos/keyring 1.2.0 seems to remove the warnings I will do more testing with the keyring but I'll likely prefer using this fork, however I don't think this will have any effect on projects that are including a replace directive on their go.mod (like is our case)

@ethanfrey
Copy link
Member

osmosis v11 and Gaia main seem to be in agreement and I would trust the choices they make.

Those are two of the most knowledgeable teams about Cosmos SDK internals and working in those repos to provide stable features for production blockchain.

@ethanfrey
Copy link
Member

That is use:

github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4
github.com/99designs/keyring v1.2.1

@ethanfrey ethanfrey modified the milestones: v0.30.0, v0.29.0 Sep 6, 2022
@alpe alpe self-assigned this Sep 7, 2022
@alpe alpe closed this as completed in #985 Sep 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants