Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feat] Support Python v3.7+ to support Splunk v8 #10

Closed
8 tasks done
geertjanvdk opened this issue May 26, 2020 · 0 comments · Fixed by #9
Closed
8 tasks done

[Feat] Support Python v3.7+ to support Splunk v8 #10

geertjanvdk opened this issue May 26, 2020 · 0 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@geertjanvdk
Copy link
Contributor

geertjanvdk commented May 26, 2020

Currently, the code of this add-on for Splunk is Python v2.7, and not compatible with Python v3.
We need to convert the code to be working using Python v3.7 greater. It would also be great that we actually test most of the code without needing Splunk (or even TIE).

Why

Splunk Enterprise v8 rightfully does not support Python v2.7 since EoL.

What

  • Code should be running with Python v3 (this is minimal work)
  • Most code should be testable without Splunk, as most functionality is within the script fetching IoCs.
  • Extend functionality so that upgrading or installing the new version of the add-on is less of a pain.
  • Revamp the README with more goodies.

This is unconditional, and we need to move on to future. We should not support Python v2.7 any longer, or keep two code bases or keep one compatible with 2 major versions

How

  • Python code made Python v3 (2to3 to the rescue)
  • Get rid of requirements.txt: none of the listed packages is needed
  • Support configuring the Sequence Number in when setting up the add-on
  • Better naming of the AddOn
  • Make distributing less a pain, and make sure the filename says what it is, and what version is contained
  • Logging to file or stderr: painful to use now
  • Improve more the help when setting the add-on, and also explain in the README.
  • Learn Splunk!!!!111
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant