Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable live update of Bloom filter #85

Closed
satta opened this issue Jul 28, 2021 · 3 comments · Fixed by #86
Closed

Enable live update of Bloom filter #85

satta opened this issue Jul 28, 2021 · 3 comments · Fixed by #86
Assignees
Labels
enhancement New feature or request

Comments

@satta
Copy link
Member

satta commented Jul 28, 2021

It would be useful to be able to add new items to the currently running Bloom filter. A way of doing this would be to add a new fever bloom subcommand, which would allow to do things like:

  • fever bloom add foo.bar to add a new indicator
  • fever bloom show to display information about the state of the currently active Bloom filter
  • fever bloom reload to reload the currently configured filter from disk
  • fever bloom sync fever bloom save to sync the current memory state to disk

This subcommand could for example communicate with the FEVER process via a control socket.

@satta satta added the enhancement New feature or request label Jul 28, 2021
@mavam
Copy link

mavam commented Jul 28, 2021

I find sync a bit abstract. Maybe just use save and load, as they are nice duals to each other?

@satta
Copy link
Member Author

satta commented Jul 28, 2021

Agreed. bloom reload and bloom save it is. I'd prefer to call it reload instead of load to stress that we only handle the preconfigured Bloom filter path.

@mavam
Copy link

mavam commented Jul 28, 2021

I'd prefer to call it reload instead of load to stress that we only handle the preconfigured Bloom filter path.

I have no strong opinion on this one. But you could also argue that this restriction may be weakened in the future.

@satta satta self-assigned this Jul 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants