Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"My sources" page and sidebar should be ordered by date updated #1468

Closed
annamorphism opened this issue May 21, 2024 · 5 comments · Fixed by #1472 or #1504
Closed

"My sources" page and sidebar should be ordered by date updated #1468

annamorphism opened this issue May 21, 2024 · 5 comments · Fixed by #1472 or #1504
Labels
priority: medium simple fix Should be straightforward to implement

Comments

@annamorphism
Copy link

How are sources supposed to show up in "My sources"? I am an editor for some sources but they don't seem to be in "my sources", so what determines this?

@annamorphism annamorphism added the question Further information is requested label May 21, 2024
@dchiller
Copy link
Contributor

It looks like the logic is that it includes sources that were either (a) created by you or (b) for which you are listed as a "current editor".

Could you give me an example of such a source, and then I can look at which "role" you have with the source that isn't one of these two?

@annamorphism
Copy link
Author

wait, I found the sources I thought I was lacking after all--weirdly, buried in different places in my (very long) list of sources, even though I thought I was added to both as an editor at the same time pretty recently (so I was expecting them together and near the surface.) So the logic is sound, it's actually a question of the order things are presented to the user (probably the most recently modified should be at the top?)

@lucasmarchd01 lucasmarchd01 changed the title What should be in "My sources"? "My sources" page and sidebar should be ordered by date updated May 22, 2024
@lucasmarchd01 lucasmarchd01 added priority: medium simple fix Should be straightforward to implement and removed question Further information is requested labels May 22, 2024
@lucasmarchd01
Copy link
Contributor

lucasmarchd01 commented May 22, 2024

There is also the "Sources created by user" sidebar. To me it makes more sense to keep it ordered by date created instead of date updated, but we can easily change that as well.

@dchiller
Copy link
Contributor

dchiller commented Jun 4, 2024

There is also the "Sources created by user" sidebar. To me it makes more sense to keep it ordered by date created instead of date updated, but we can easily change that as well.

Ok, in testing on staging it looks like #1472 changed the ordering of the "Sources created by user" sidebar, but not the main source list on the "My Source" page.

@lucasmarchd01
Copy link
Contributor

See #1500.

The sidebar on the My Sources page should be changed back to ordering by date created and the list in the table should be ordered by date updated

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority: medium simple fix Should be straightforward to implement
Projects
None yet
3 participants