Chant Detail: fix bug where we would send a request to a cantusindex.org/json-con/cantus_id/refresh #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…org/json-con/cantus_id/refresh
dchiller
approved these changes
Sep 19, 2023
lucasmarchd01
approved these changes
Sep 19, 2023
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1052
When starting the thread to ping
cantusindex.org/json-con/{some cantus id}/refresh, we were passing in a dictionary. Python was calling_refresh_ci_json_con_apiusing the key,"cantus_id", as an argument, rather than using the value. I'm confident this was working several months ago when first implemented, so I don't know what changed to create this bug. In any case, since_refresh_ci_json_con_apitakes only a single argument, we can start the thread by passing in a list of arguments rather than a dictionary.Once this change ends up on production, I need to remember to send Jan an email saying this is fixed.