-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merge Staging into Production, 2023-Dec-05 edition #1196
Conversation
This reverts commit db7e9ea.
Delete management commands we no longer need
Update json-cid API to conform to new specification
Update Diff DB labels and links
Use icontains for provenance autocomplete
so that we only search by Cantus ID when the search term contains at least one number, rather than one non-letter character
where we should have returned the chant's source's siglum
search bar, Chant Search page: Update policy on when we search by incipit and when we search by Cantus ID
Add django-reversion
Merge Develop into Staging, 2023-Dec-05 edition
Upon merging this PR, the following tasks will be required while updating the Production server:
Once the new code is running on Production, the following tasks will need to be completed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the user-facing changes look good to me!
@jacobdgm Is this the one where you'd like us to check them off? |
Approving....everything looks good to me except for the one about the admin area, which I can't access :) The only one that acts buggy is this one:
The auto-population works, but it shows up first without it populated and then takes a few seconds to populate...any idea why that is taking time? |
We have some JS that runs when the page loads. Maybe this could be refactored to make it happen more instantaneously. I'll let you create an issue for this if you think it's important enough to address. We could maybe refactor several pages to use |
I see now that this is not a change impacted by this PR -- I just tested that it happens (if interestingly with a shorter lag) on production as well right now. All good. |
so I found #1205, but this is a bug already present on Production, and not big enough IMO to prevent us from taking the current changes to Production. |
These changes are now up on Production! Waiting for Update: |
Things that have been updated:
siglum
, rather than the chant'ssiglum
django-reversion
for version control of objects in database, traces of which can be found in many places in the Admin Areaicontains
search instead ofistartswith
icontains
search instead ofistartswith
"sequence"
"cantus_id"
"fulltext"
is now"full_text"
sync_chants
sync_feasts
sync_genres
sync_indexers
sync_sequences
sync_source_creation_date
sync_sources
add_all_users
update_differentia_new
merge_indexer_user
replace_indexer_fields
populate_volpiano_new_fields
populate_next_chant_fields
populate_is_last_chant_in_feast
populate_chant_and_melody_counts
add_unknown_source
add_prefix
(commit, which was mislabelled)add_differentiae
populate_chant_fields
->touch_all_chants