Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix "Browse Chants" page "Source" drop-down bug #1362

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

lucasmarchd01
Copy link
Contributor

This PR addresses the bug that was found on the chant-list page.

When the user would select a different source from the drop-down menu, instead of being redirected to
source/<int:source_id>/chants/ they get sent to /source/<int:source_id>/chants/?folio=&feast=&search_text=&genre=&source=<int:new_source_id>

There was some discussion in #1336 about whether this functionality is useful to users on the site. Perhaps the best option is to remove it altogether, but in the meantime it should work as expected for users that might be browsing this way.

The code modified includes the chant_list.js file which handles the filters. The page will now redirect correctly and the source parameter is no longer used in the URL. Additionally, the current source that the user is browsing is correctly displayed as the selected option in the drop-down menu.

Example after selecting a new source from the drop-down menu:

Screenshot 2024-03-14 at 5 38 39 PM

Screenshot 2024-03-14 at 5 38 26 PM

Fixes #1336, Fixes #717

Copy link
Contributor

@jacobdgm jacobdgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one small tweak to a variable name, but on the whole, this looks very good. Thanks!

@lucasmarchd01 lucasmarchd01 merged commit 9057bdd into DDMAL:develop Mar 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants