Fix cron script issues related to docker version upgrade on new servers #1490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this Docker documentation, when Docker compose specifications migrated from V1 to V2, the word separator in the default container name changed from an underscore to a hyphen. Our new servers, with their upgraded version of Docker, use the hyphen. Since the documentation suggests an underlying networking reason for this change, this PR implements it.
The relevant container name in the
db_backup.sh
script is changed (cantusdb_postgres_1
tocantusdb-postgres-1
).This PR also updates all
docker-compose
files in this repo to specify the container name (although our scripts now conform to this naming convention, it doesn't hurt to make it explicit).The
docker-compose
command was also deprecated with the version of Docker server used on the new servers. This PR adjusts themanage.sh
cron script to usedocker compose
rather thandocker-compose
.Closes #1489.
A companion PR in the ansible set-up (https://github.com/dact-chant/ansible.cantus-db/pull/39) makes the analogous change in the
docker-compose.yml
template.