Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

df_import_structures does not properly adduce minimum sizes of enums with negative values #31

Open
ab9rf opened this issue Dec 10, 2022 · 0 comments

Comments

@ab9rf
Copy link
Member

ab9rf commented Dec 10, 2022

df_import_structures identifies the building_type enum as requiring 32 bits even though it can fit in 16 (indeed probably 8) because the enum includes a value NONE with value -1. the enum imported into ghidra encodes this value as 0xffffffff instead of as -1 (which itself isn't necessarily wrong) and thus concluded from this that the enum required 4 bytes (which is)

@ab9rf ab9rf transferred this issue from DFHack/dfhack Jan 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant