Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix HoYoLAB accounts login #1012

Closed
wants to merge 3 commits into from
Closed

Fix HoYoLAB accounts login #1012

wants to merge 3 commits into from

Conversation

Xhichn
Copy link
Contributor

@Xhichn Xhichn commented Oct 13, 2023 •
edited
Loading

  • Fix hoyolab web login
  • Allow adding hoyolab account by v2 stoken using "Input Manually"
  • Fix hoyolab daily reward claim

Legacy stoken still works for now. Currently v2 stoken can only be obtained by capturing requests from hoyolab mobile app.

@Masterain98 Masterain98 requested a review from Lightczx October 13, 2023 10:22
@Masterain98 Masterain98 added the area-Hoyoverse 国际服支持 label Oct 13, 2023
@Masterain98
Copy link
Member

Resolve #1011

@Xhichn
Copy link
Contributor Author

Xhichn commented Oct 13, 2023

Last commit e572709 may resolve #1013.
But I don't really know why the app crashes. It looks like a new web page is presented.

Lightczx added a commit that referenced this pull request Oct 13, 2023
@Lightczx
fix #1013 #1012 #1011
06c5bca
@Lightczx
Copy link
Member

I believe we are using SToken v1 for HoYoLAB currently, and there is no urge to use v2 now
I have already pick out the fix part 06c5bca

@Lightczx Lightczx closed this Oct 13, 2023
@Xhichn Xhichn deleted the develop branch October 13, 2023 16:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lightczx Lightczx Awaiting requested review from Lightczx

Assignees
No one assigned
Labels
area-Hoyoverse 国际服支持
Projects
Snap Hutao Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xhichn @Masterain98 @Lightczx