Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong case in 'img' tag 'src' attributes #224

Open
henrikt-ma opened this issue Feb 11, 2025 · 0 comments
Open

Wrong case in 'img' tag 'src' attributes #224

henrikt-ma opened this issue Feb 11, 2025 · 0 comments

Comments

@henrikt-ma
Copy link

In a small number of cases, image files are referred to using an upper case PNG filename extension:

➜  ThermofluidStream-main git:(main) ✗ git grep '.PNG' -- '*.mo' | cat
ThermofluidStream/FlowControl/MCV.mo:<p><img src=\"modelica://ThermoFluidStream/Resources/Doku/ThermofluidStream.FlowControl.MCV.PNG\"/></p>
ThermofluidStream/Processes/Internal/FlowResistance/laminarTurbulentPressureLoss.mo:<p><img src=\"modelica://Thermofluidstream/Resources/Doku/ThermofluidStream.Processes.Internal.FlowResistance.laminarTurbulentPressureLoss.PNG\"/></p>
ThermofluidStream/Processes/Internal/TurboComponent/dp_tau_const_isentrop.mo:<img src=\"modelica://ThermofluidStream/Resources/Doku/ThermofluidStream.Processes.Internal.dp_tau_const_polytrop_skewness.PNG\"/>
ThermofluidStream/Processes/Internal/TurboComponent/dp_tau_const_isentrop.mo:<img src=\"modelica://ThermofluidStream/Resources/Doku/ThermofluidStream.Processes.Internal.dp_tau_const_polytrop_skewness2.PNG\"/>
ThermofluidStream/Topology/Internal.mo:<p><img src=\"modelica://ThermofluidStream/Resources/Doku/ThermofluidStream.Topology.Internal.SplitterRatio.PNG\"/><img src=\"modelica://ThermofluidStream/Resources/Doku/ThermofluidStream.Topology.Internal.SplitterRatio2.PNG\"/></p>
ThermofluidStream/Undirected/Processes/TransportDelay.mo:<p><img src=\"modelica://ThermofluidStream/Resources/Doku/ThermofluidStream.Processes.Tests.TransportDelay_artefacts2.PNG\"/> <img src=\"modelica://ThermofluidStream/Resources/Doku/ThermofluidStream.Processes.Tests.TransportDelay_artefacts.PNG\"/> </p>

This does not match the few cases of files actually having upper case in the filename extension:

➜  ThermofluidStream-main git:(main) ✗ find . -name '*.PNG'           
./ThermofluidStream/Resources/Doku/ThermofluidStream.Topology.Internal.SplitterRatio.PNG
./ThermofluidStream/Resources/Doku/ThermofluidStream.FlowControl.MCV.PNG
./ThermofluidStream/Resources/Doku/ThermofluidStream.Processes.Internal.FlowResistance.laminarTurbulentPressureLoss.PNG
./ThermofluidStream/Resources/Doku/ThermofluidStream.Topology.Internal.SplitterRatio2.PNG
./doc/VideoThermoFluidCover.PNG

On case sensitive file systems, this will result in missing images in the documentation.

I would recommend fixing this by consistently using the more common variant with png in lower case.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant