Skip to content

Update Project Details to accommodate contributors #2408

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
briri opened this issue Feb 26, 2020 · 6 comments
Closed

Update Project Details to accommodate contributors #2408

briri opened this issue Feb 26, 2020 · 6 comments
Assignees
Labels
effort-large 1-3 days of dev time maDMP machine-actionable DMPs plans

Comments

@briri
Copy link
Contributor

briri commented Feb 26, 2020

A new table, contributors, was added as part of #2349.

The new Contributors model uses the CRediT Taxonomy for contributor role types.

We need to add a new section that allows a user to identify additional contributors to their project. The section should work similar to the 'links' section on the Org details page with a button/link to add another and 'x' buttons to remove them as needed.

Generate an upgrade task that converts existing PIs and Data Contacts into Contributors.

We will also need to update any code that creates or copies a new plan and have it assign the owner/creator as the Data Contact (aka data_curation role) and Author (aka writing_original_draft role).

We must either update the existing Share tab and have it manage contributor records for the following (add/remove/change role):

  • Co-owner --> writing_original_draft
  • Editor --> writing_review_editing (possibly?)
  • Commenter --> No contributor role
    OR we should consolidate the the contributor section on the Share tab with the new Contributors tab.

Also need to determine if a 'Feedback' reviewer should be assigned the writing_review_editing contributor role.

@briri briri added plans effort-large 1-3 days of dev time maDMP machine-actionable DMPs labels Feb 26, 2020
@briri
Copy link
Contributor Author

briri commented Mar 16, 2020

Here is a screenshot of a proposed new tab that allows researchers to define contributors:
Screen Shot 2020-03-16 at 3 14 56 PM

We will need a blurb at the top that explains who these contributors are and why they should tell us about them.

First though, we need to determine whether 'contributors' are defined as 'the people working on/with the DMP itself', 'the people involved with the project' or some combination of the 2.

Who can add/edit/remove contributors? I have it set to owners and co-owners only for now.

My current plan is to:

  • Create a contributor for every plan with the roles of 'Data Curation' and 'Writing original draft'. The name/email/etc. will either come from the 'Data Contact' if defined or the plan's owner
  • Create a contributor with a role of 'Writing original draft' for every co-owner of a plan.
  • Create a contributor with a role of 'Investigation' for every PI defined on a plan
  • Remove the old 'Data Contact' and 'PI' info since its now in the Contributors table
  • Update the create plan logic to automatically make the plan creator a 'Data Curation' and 'Writing original draft' roles
  • Update the share plan page to create/edit/delete contributor records when the user adds co-owners
  • Update the my dashboard page to remove the contributor role when a user removes themselves from a plan (does this make sense or should we keep the contributor association for historical purposes?)
  • Make sure that the copy plan functionality does not carry over contributor info

@mariapraetzellis
Copy link

@sjDCC @magdalenadrafiova @mariapraetzellis To come up with text that explains to users who needs to be added to the Contributors list to make it clear what we're looking for.

@briri briri self-assigned this Mar 17, 2020
@mariapraetzellis
Copy link

Considering "Please list the project’s Principle Investigator(s) and those responsible for data management." @sjDCC what do you think?

@sjDCC
Copy link
Contributor

sjDCC commented Apr 24, 2020

I think the PI should be auto-listed as the person who created the plan. They can then edit if they have another role. Better to avoid them having a completely blank table at first.

If we roll this in with the plan co-authoring feature, perhaps text like:

"Please list project collaborators to ensure credit for contributions and assign authoring / viewing permissions for the DMP"

@briri
Copy link
Contributor Author

briri commented Apr 24, 2020

consolidated the PI change with the list on #2481

@sjDCC
Copy link
Contributor

sjDCC commented Apr 27, 2020

Request captured in new ticket so closing out

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
effort-large 1-3 days of dev time maDMP machine-actionable DMPs plans
Projects
None yet
Development

No branches or pull requests

3 participants