Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Compilation problems due to "version" file #5374

Closed
oleg-alexandrov opened this issue Dec 12, 2023 · 0 comments · Fixed by #5434
Closed

Compilation problems due to "version" file #5374

oleg-alexandrov opened this issue Dec 12, 2023 · 0 comments · Fixed by #5434
Assignees
@AustinSanders
Labels
bug Something isn't working

Comments

@oleg-alexandrov
Copy link
Contributor

oleg-alexandrov commented Dec 12, 2023 •
edited
Loading

ISIS version(s) affected: latest

Description

When building and installing ISIS in a conda directory, it installs a file named "version". A subsequent compilation pass of ISIS fails in json.

It appears that the problem is due to the fact that "version" is a reserved header of the standard library (nlohmann/json#4241).

Since the standard C++ library will refuse to budge, ISIS may need to call its file "isis_version", or something.

How to reproduce

Possible Solution

Additional context
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@AustinSanders AustinSanders

Labels
bug Something isn't working
Projects
Astro Software Support Sprint
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed 'version' filename to honor reserved keyword. AustinSanders/ISIS3
2 participants
@oleg-alexandrov @AustinSanders