Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

1.4.0 - Error: Cannot find module '../config' #22

Closed
manikumarrepuri opened this issue Apr 20, 2020 · 3 comments
Closed

1.4.0 - Error: Cannot find module '../config' #22

manikumarrepuri opened this issue Apr 20, 2020 · 3 comments

Comments

@manikumarrepuri
Copy link

Everything was fine with the earlier version, but suddenly my tests started failing then had a look at the version and it's 1.4.0 now.
Verified downgrading the version and my tests passed.

Throwing error "Cannot find module '../config'.

@srinivasrk
Copy link

srinivasrk commented Apr 20, 2020

I can see that in schema.js file inside lib you are require ../config but config in not in the previous directory. It should be ./config I can create a PR to fix this.

Here: https://github.com/DScheglov/mongoose-schema-jsonschema/blob/master/lib/schema.js

Created a PR to fix that here:
#23

Please review @DScheglov
Thank you

@DScheglov
Copy link
Owner

Fixed in v1.4.1.

Thanks for fast issue

@manikumarrepuri
Copy link
Author

Thanks for the swiftly fix. Excellent.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants