Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updating Rust Driver version and setting a Custom Driver name/version #35

Open
danielhe4rt opened this issue Aug 6, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@danielhe4rt
Copy link
Collaborator

Currently, we're using an outdated Scylla Rust Driver version and we need maintain it on LTS. But more than that, we gonna need to implement a different driver name under the Rust Driver (for identification inside the Cluster).

Thinking on that, the drivers team recently merged a possibility to settle the driver name/version (scylladb/scylla-rust-driver@36d5edd)

let session: Session = SessionBuilder::new()
  .known_node("127.0.0.1:9042")
  .custom_identity(
     SelfIdentity::new()
       .with_custom_driver_version("0.3.17")
       .with_application_name("ScyllaDB JavaScript Driver")
       .with_application_version(app_version_from_package_json),
  );

Goal

Upgrade the driver version and validate missing rules to implement this feature.

@Daniel-Boll
Copy link
Owner

We could try to change from getting the version from the package.json to the CARGO_PKG_VERSION one instead, it's easier to achieve this in Rust. The only thing that we will need to change to this to happen is sync the package.json bump version to the cargo.toml too.

@Daniel-Boll Daniel-Boll self-assigned this Aug 6, 2024
@Daniel-Boll Daniel-Boll added the enhancement New feature or request label Aug 6, 2024
@danielhe4rt
Copy link
Collaborator Author

Hmm, since it will be generating a binary every time I don't think that this can be an issue. We will just have to change this in the Rust side for the versioning...

Apparently Scylla folks are defining a name like the one I sent here so it's only up to versioning.

Repository owner deleted a comment from danielhe4rt Oct 23, 2024
Daniel-Boll pushed a commit that referenced this issue Nov 9, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants