Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Conflict with Alternative's <|> #41

Open
istathar opened this issue Sep 12, 2016 · 6 comments
Open

Conflict with Alternative's <|> #41

istathar opened this issue Sep 12, 2016 · 6 comments

Comments

@istathar
Copy link
Contributor

I'm sure you're aware, but an operator named <|> is a part of the Alternative typeclass from Control.Applicative. Since that's in base now, I don't think it's wise for matrix to export a function with the same name for joining blocks.

Not the end of the world.

@octopuscabbage
Copy link
Contributor

Any proposals as to what it's changed to?

@Daniel-Diaz
Copy link
Owner

Right, <|> was a terrible name to choose. We need to change it. I'm happy to see your suggestions. Maybe <||>? The issue with this is backwards compatibility. We should first make a release with both the old and the new name, with the old being marked as deprecated.

@octopuscabbage
Copy link
Contributor

Seems like the best alternative (no pun intended) I did some Googling and couldn't find a better looking operator. Would we change the vertical join?

@istathar
Copy link
Contributor Author

istathar commented Oct 3, 2016

If two lines is your thing, then <=>?

Personally I would just have gone with

one
`above`
two

and

three `beside` four

but that's just me. :)

@octopuscabbage
Copy link
Contributor

Yeah, the fact that we can't really come up with a good operator makes me think that concatenation isn't really worth an operator. I think your suggestion of above and beside is fine, except it looks kind of weird not infix. Maybe verticalConcat and horizontalConcat or something.

@istathar
Copy link
Contributor Author

@Daniel-Diaz do you want to make a decision about this, or are you waiting for a patch before passing judgment?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants