Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Code review week 5 #1

Open
tjouni opened this issue Jun 6, 2019 · 0 comments
Open

Code review week 5 #1

tjouni opened this issue Jun 6, 2019 · 0 comments

Comments

@tjouni
Copy link

tjouni commented Jun 6, 2019

The code is well structured and commented. Some javadocs need updating, e.g. the TreeNode constructor has parameters leftChild and rightChild in javadoc, but not in the actual code.

Code is easy to read and I understood easily what it was supposed to do. Test coverage and tests in general look ok.

Great work in general!

Edited the part about strings, realised I understood the code wrong. Nice implementation, although I think in this course you are supposed to implement the substring method by yourself.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant