Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MAINT: cost_options argument in smash.optimize_control_info() could be removed #302

Closed
nghi-truyen opened this issue Aug 9, 2024 · 0 comments · Fixed by #320
Closed
Assignees

Comments

@nghi-truyen
Copy link
Member

The cost_options argument in smash.optimize_control_info() seems to be redundant. However, the one in smash.bayesian_optimize_control_info() is necessary to define both sg0 and sg1 parameters (depending on calibrated gauges).

Note: The two new methods will be added to smash taking exactly the same arguments of smash.optimize_control_info() and smash.bayesian_optimize_control_info() methods. These methods would enable users to retrieve the model object from a control vector solution.

@nghi-truyen nghi-truyen self-assigned this Aug 9, 2024
@nghi-truyen nghi-truyen changed the title cost_options argument in smash.optimize_control_info() could be removed MAINT: cost_options argument in smash.optimize_control_info() could be removed Aug 9, 2024
@nghi-truyen nghi-truyen linked a pull request Sep 13, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant