Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Git rebase forces the user to touch his yubikey for every single commit #19

Closed
antoine-gaillard opened this issue Mar 12, 2019 · 5 comments
Labels
wontfix This will not be worked on

Comments

@antoine-gaillard
Copy link

When doing a git rebase you have to touch your key for every single commit being replayed this can take quite some time if you rebase a bunch of them

@trishankatdatadog
Copy link
Member

I'm not sure what we can do about this, because it's really a Yubikey design issue, which apparently suggests that Yubico itself does not use GPG on its own keys to sign its git commits.

I'm afraid that if you rebase a lot, you probably have to turn off the touch 2FA on your Yubikey.

@SantiagoTorres Are you aware of any workaround?

It might be best to reach out to someone at Yubico about this.

@SantiagoTorres
Copy link

Unfortunately, I think there's no workaround this issue. I think you could, for the sake of usability, just sign the tip of the rebased commits:

git rebase $FLAGS --no-gpg-sign && git commit --amend

We could probably think of a way to make this smarter using libgit2 but I wonder if it's worth the hassle...

@trishankatdatadog trishankatdatadog added the wontfix This will not be worked on label Mar 12, 2019
@trishankatdatadog
Copy link
Member

@SantiagoTorres I like your workaround, I think it's the simplest thing we can do 👍

@trishankatdatadog
Copy link
Member

@SantiagoTorres However, a downside to this approach is that rebased commits are left unsigned, right? This might cause issues when you are pushing to a protected GitHub branch that requires signed commits, no? Then we might need merge strategies there to solve the problem...

@SantiagoTorres
Copy link

Yeah, unfortunately n-1 of the commits won't be signed. We can see if there's a ccid message we can use to have it sign multiple payloads after the fact, but this seems too painful firsthand :(

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants