Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Code to Create presidential_speech data set #27

Open
michaelweylandt opened this issue Sep 15, 2018 · 3 comments
Open

Code to Create presidential_speech data set #27

michaelweylandt opened this issue Sep 15, 2018 · 3 comments
Assignees
Labels
Documentation Documentation-related issues New Feature New or enhanced functionality

Comments

@michaelweylandt
Copy link
Member

Add code to (re)create presidential_speech data set. This will allow the data set to be re-run as more speeches are recorded. (If we update the "official" version in the package, we may need to version it somehow.)

@michaelweylandt michaelweylandt added the New Feature New or enhanced functionality label Sep 15, 2018
@michaelweylandt michaelweylandt added the Documentation Documentation-related issues label Sep 15, 2018
@jjn13
Copy link
Collaborator

jjn13 commented Sep 17, 2018

Do we have a preference for where this should be in the project directory structure?

The code has an R script (used for text processing), but also uses python for web scraping, and some bash scripts for moving things around. In total, it's really a small set of directories.

Do we want to add as a .zip for example, or copy over the whole directory?

@michaelweylandt
Copy link
Member Author

By default, I'd put it in inst (i.e., random files that get installed but not used by the package), but I think that the data-raw directory is also a common choice. See http://r-pkgs.had.co.nz/data.html#data-extdata

@jjn13
Copy link
Collaborator

jjn13 commented Sep 17, 2018

sounds good, I've submitted as #40

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Documentation Documentation-related issues New Feature New or enhanced functionality
Projects
None yet
Development

No branches or pull requests

2 participants