Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

U Smoothing #63

Open
1 of 4 tasks
michaelweylandt opened this issue Oct 19, 2018 · 1 comment
Open
1 of 4 tasks

U Smoothing #63

michaelweylandt opened this issue Oct 19, 2018 · 1 comment
Assignees
Labels
Algorithms Improvements to core CARP/CBASS algorithms Graphics Improvements to graphics-related functionality

Comments

@michaelweylandt
Copy link
Member

michaelweylandt commented Oct 19, 2018

Add a post-processing step to "smooth" U by replacing the U-hat for clustered elements with the mean U-hat for elements in that cluster. This won't change the implied clusterings, but it will improve some minor problems with the path graphics, where the centroids do not exactly coincide.

(Note that this isn't a real CARP / CBASS issue but rather an deeper issue with running the ADMM for a finite amount of time on these problems: similar to how interior point methods will never get exact zeros even when run to essentially numerical convergence on the lasso and need a final thresholding step.)

Once this is done, we can speed up plotting by only showing the distinct path elements instead of every path element. The plot_frame elements passed to ggplot can go through a dplyr::distinct first to speed things up / avoid massive over-plotting. This should alleviate some of the slowness issues at the heart of #56.

TODO:

  • Add CARP U smoothing
  • Add CBASS U smoothing
  • Update get_cluster_centroids and get_clustered_data
  • Speed up path plotting
@michaelweylandt michaelweylandt added Algorithms Improvements to core CARP/CBASS algorithms Graphics Improvements to graphics-related functionality labels Oct 19, 2018
@michaelweylandt
Copy link
Member Author

This was addressed for CARP in #77 but is still open for CBASS so I'm not closing the issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Algorithms Improvements to core CARP/CBASS algorithms Graphics Improvements to graphics-related functionality
Projects
None yet
Development

No branches or pull requests

2 participants