Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fungus cannot be bonemealed #38

Open
unascribed opened this issue Aug 22, 2023 · 0 comments
Open

Fungus cannot be bonemealed #38

unascribed opened this issue Aug 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@unascribed
Copy link

unascribed commented Aug 22, 2023

Noticed in the BlanketCon 23 pack with Dark Amaranth Fungus from Promenade, but not reporting there as it's not important for the con.

Due to a change in the signature of isFertilizable the method in DawnFungusBlock is no longer an override. As such, it falls back to the super implementation — which always fails due to passing null for the nylium argument in the constructor. This is easily checked by decompiling the resulting DawnAPI jar and noting that the method is not reobfuscated to method_9651 as it should be. The method now takes WorldView rather than BlockView.

This exact issue is what @Override is meant to catch — you should tag every single method that overrides a super with it so you're alerted with a compile error if the name or signature of the method you're overriding changes.

@unascribed unascribed added the bug Something isn't working label Aug 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant