Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Search and Pin subscriptions #217

Closed
wants to merge 2 commits into from
Closed

Conversation

shen-tian
Copy link
Contributor

Address #176

  • Search subscriptions by name
  • Able to pin subscriptions (pinned subs appear at the top of the list)
  • Given the above, subscriptions are sorted by name

I haven't put much effort into styling this. Want to get some feedback on approach before going further.

@shen-tian
Copy link
Contributor Author

@danielcompton would you have a chance to have a look?

@danielcompton
Copy link
Contributor

danielcompton commented Feb 3, 2019

Thanks for this, I agree that sorting subscriptions by name feels more natural.

I've merged this now behind the debug flag. I'll need to get @mike-thompson-day8 to go through the styling, but it's available now if you turn on the debug flag:

"re-frame-10x has a debug panel useful when developing it. " - https://github.com/Day8/re-frame-10x/blob/master/DEVELOPERS.md

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants