From 7564e32d754c4c0957dd738b42e6d28b2ce226c5 Mon Sep 17 00:00:00 2001
From: DeeDeeG <DeeDeeG@users.noreply.github.com>
Date: Fri, 27 Oct 2023 22:52:37 -0400
Subject: [PATCH] CI: Move "Check Engines" job to its own workflow file

---
 .github/workflows/check-engines.yml | 28 ++++++++++++++++++++++++++++
 .github/workflows/tests.yml         | 17 -----------------
 2 files changed, 28 insertions(+), 17 deletions(-)
 create mode 100644 .github/workflows/check-engines.yml

diff --git a/.github/workflows/check-engines.yml b/.github/workflows/check-engines.yml
new file mode 100644
index 0000000000..6410a8da42
--- /dev/null
+++ b/.github/workflows/check-engines.yml
@@ -0,0 +1,28 @@
+name: Check Engines
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+permissions:
+  contents: read # to fetch code (actions/checkout)
+
+jobs:
+  Engines:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout Repository
+      uses: actions/checkout@v3
+    - name: Use Node.js 20.x
+      uses: actions/setup-node@v3
+      with:
+        node-version: 20.x
+    - name: Install Dependencies
+      run: |
+        npm install --no-progress
+    - name: Check Engines
+      run: |
+        npm install @npmcli/arborist@7 semver@7 --no-save
+        node .github/scripts/check-engines.js
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 29525b8a73..310b4f06ea 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -18,23 +18,6 @@ jobs:
     - uses: actions/checkout@v4
     - run: pip install --user ruff
     - run: ruff --output-format=github --select="E,F,PLC,PLE,UP,W,YTT" --ignore="E721,PLC1901,S101,UP031" --target-version=py38 .
-  Engines:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout Repository
-      uses: actions/checkout@v3
-    - name: Use Node.js 20.x
-      uses: actions/setup-node@v3
-      with:
-        node-version: 20.x
-    - name: Install Dependencies
-      run: |
-        npm install --no-progress
-    - name: Check Engines
-      run: |
-        # TODO: move this to its own action
-        npm install @npmcli/arborist@7 semver@7 --no-save
-        node .github/scripts/check-engines.js
   Tests:
     needs: Lint_Python  # Lint_Python takes ~5 seconds, so wait for it to pass before running the full matrix of tests.
     strategy: