Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Memory leak? #70

Closed
MapleStoryPSN opened this issue Feb 4, 2021 · 3 comments
Closed

Memory leak? #70

MapleStoryPSN opened this issue Feb 4, 2021 · 3 comments

Comments

@MapleStoryPSN
Copy link

Tested on both the current bsnes-hd beta retroarch core and standalone emulator. Launch any game and monitor ram usage. It will gradually climb at a rate of roughly 1mb a second, even if left completely idle in game on a static screen. No other SNES cores, base bsnes included, exhibit this behavior.

@DerKoun
Copy link
Owner

DerKoun commented Feb 4, 2021

Great find, thank you.
That is what happens when a Java developer wades through the circle of hell that is C++. He doesn't deallocate his arrays.
There were two happening every frame(!!) and one when you change Color Adjustments. And all together were literarily fixed with 3 lines of code.

@DerKoun
Copy link
Owner

DerKoun commented Feb 6, 2021

This fix is now live for the libretro core. That also fixes breaking flickering on the Switch.

@DerKoun
Copy link
Owner

DerKoun commented Feb 20, 2021

Fixed in the new beta 10.4
@MapleStoryPSN If you have time to verify I'd appreciate it.

@DerKoun DerKoun closed this as completed Feb 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants