Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Simulation stop on wednesday #80

Closed
totomaze opened this issue Oct 31, 2016 · 3 comments
Closed

Simulation stop on wednesday #80

totomaze opened this issue Oct 31, 2016 · 3 comments

Comments

@totomaze
Copy link

Hi,

Does someone know where is the piece of code that set the end of the simulation on the last wednesday ?

Thanks
@JFD3D
Copy link
Contributor

JFD3D commented Nov 1, 2016 •
edited
Loading

It's in the zenbrain node module, sim.js

@totomaze
Copy link
Author

totomaze commented Nov 2, 2016

Thanks,
I changed 7d to 1d and increase the backillday.

@totomaze totomaze closed this as completed Nov 2, 2016
@JFD3D
Copy link
Contributor

JFD3D commented Nov 5, 2016

It's set to Wednesday so that the simulations stay constant for that period of time, if you change it to 1 day your simulations will kick out ROI's that vary based on day to day price fluctuations. It is much harder to dial in an 'overfit' strategy.

@snyk-bot snyk-bot mentioned this issue Mar 30, 2020
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@totomaze @JFD3D