Merge pull request #810 from Devsh-Graphics-Programming/bad_capability_bitcast

devshgraphicsprogramming · web-flow · commit 987a5deab1d3 · 2025-01-13T10:42:58.000+01:00
Stop bitcast emitting the BDA capability if bitcasting between SPIR-V builtin types
diff --git a/include/nbl/builtin/hlsl/spirv_intrinsics/core.hlsl b/include/nbl/builtin/hlsl/spirv_intrinsics/core.hlsl
@@ -200,7 +200,6 @@ void memoryBarrier(uint32_t memoryScope, uint32_t memorySemantics);
 
 // Add specializations if you need to emit a `ext_capability` (this means that the instruction needs to forward through an `impl::` struct and so on)
 template<typename T, typename U>
-[[vk::ext_capability(spv::CapabilityPhysicalStorageBufferAddresses)]]
 [[vk::ext_instruction(spv::OpBitcast)]]
 enable_if_t<is_spirv_type_v<T> && is_spirv_type_v<U>, T> bitcast(U);
 
@@ -252,4 +251,4 @@ Matrix transpose(NBL_CONST_REF_ARG(Matrix) mat);
     }
 }
 
-#endif
+#endif

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,6 @@ void memoryBarrier(uint32_t memoryScope, uint32_t memorySemantics);`
`200`	`200`
`201`	`201`	// Add specializations if you need to emit a `ext_capability` (this means that the instruction needs to forward through an `impl::` struct and so on)
`202`	`202`	`template<typename T, typename U>`
`203`		`-[[vk::ext_capability(spv::CapabilityPhysicalStorageBufferAddresses)]]`
`204`	`203`	`[[vk::ext_instruction(spv::OpBitcast)]]`
`205`	`204`	`enable_if_t<is_spirv_type_v<T> && is_spirv_type_v<U>, T> bitcast(U);`
`206`	`205`
`@@ -252,4 +251,4 @@ Matrix transpose(NBL_CONST_REF_ARG(Matrix) mat);`
`252`	`251`	`}`
`253`	`252`	`}`
`254`	`253`
`255`		`-#endif`
	`254`	`+#endif`