Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Interactions should use connector, proxy, proxy_auth kwargs of client #261

Open
3 tasks done
shiftinv opened this issue Jan 8, 2022 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working s: planned Issue is planned in the future

Comments

@shiftinv
Copy link
Member

shiftinv commented Jan 8, 2022

Summary

Since interaction responses are webhooks and as such don't go through http.py but instead through async_.py, the connector/proxy/proxy_auth kwargs passed to Client.__init__ don't apply.

Expected Results

interaction callbacks go through the proxy and/or use the specified connector

Actual Results

they don't

Intents

all

System Information

latest / 2025dfb

Checklist

  • I have searched the open issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have removed my token from display, if visible.

Additional Context

Not only does this prevent interactions from working in configurations where a proxy is absolutely required, it's also a bit annoying when debugging HTTP reqs. The past few weeks I resorted to monkeypatching bot.http._HTTPClient__session._request, but I'm sure anyone would agree that this isn't a great solution, so it's time to change that :^)

@shiftinv shiftinv added bug Something isn't working s: planned Issue is planned in the future labels Jan 8, 2022
@shiftinv shiftinv self-assigned this Jan 8, 2022
@shiftinv shiftinv removed their assignment Jan 31, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Jun 12, 2022
@shiftinv shiftinv modified the milestones: disnake v2.6, disnake v2.7 Sep 1, 2022
@shiftinv shiftinv removed this from the disnake v2.8 milestone Feb 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working s: planned Issue is planned in the future
Projects
None yet
Development

No branches or pull requests

2 participants