Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert to Curly Quotes suggestion for single quotes. #671

Open
okrick opened this issue Jan 15, 2025 · 5 comments
Open

Convert to Curly Quotes suggestion for single quotes. #671

okrick opened this issue Jan 15, 2025 · 5 comments
Labels
future feature New feature or request, but not core

Comments

@okrick
Copy link

okrick commented Jan 15, 2025

The straight apostrophes for dialect words like ’round which begin with an apostrophe to indicate a missing character or characters are not currently converted in either GG1 or GG2 to left single quotes since one is uncertain whether these are the beginning of a quotation or an apostrophe.

If they are dialect, they are almost certainly missing character apostrophes instead of the beginning of a quotation. Dialect is nearly always within a quotation.

So I think converting any single quote at the beginning of a word after a left double quote in the same paragraph to an apostrophe would catch most of the conversions. Any other single quote that is not preceded by a left double quote in the same paragraph could be converted to a left single quote.

This should correctly convert most of the single quotes. The error rate would likely about the same as the current error rate for double quote conversions.

I believe this is a worthwhile idea for future exploration and should not detract from the current project's priorities. I understand if it's ultimately determined to be impractical.

@srjfoo
Copy link
Member

srjfoo commented Jan 15, 2025

For what it's worth, I've been setting up a testing project that has tons of dialect. But it also has genuine single-quotes nested inside double-quotes. My concern with doing the kind of automatic conversion that you mention is that if it were incorrectly converted, it might not be identified as something that needed to be checked manually.

@okrick
Copy link
Author

okrick commented Jan 16, 2025

"Tools=>Unmatched=>Curly Quotes" flags unmatched right curly quotes at word ends. A quick check should identify whether it is a false positive.

It would be helpful if the "Tools=>Unmatched=>Curly Quotes" check displayed the entire line containing unmatched curly quotes, instead of just highlighting the individual quote marks. This would significantly improve usability by allowing users to quickly identify and correct issues without having to click on each instance individually.

Furthermore, the "Tools=>Unmatched=>Curly Quotes" tool could be enhanced by incorporating the same toolset as the "Tools=>Check Curly Quotes" screen. This would provide users with a more comprehensive and efficient workflow for managing curly quotes.

Alternatively, the "Tools=>Unmatched=>Curly Quotes" tool could be entirely integrated into the "Tools=>Check Curly Quotes" test. This would streamline the process and eliminate the need for a separate, less functional tool.

@windymilla
Copy link
Collaborator

Hmm... I'm not sure of the best way forward for this.

@okrick
Copy link
Author

okrick commented Jan 16, 2025

If it's impractical then close this.

@windymilla windymilla added the future feature New feature or request, but not core label Jan 17, 2025
@windymilla
Copy link
Collaborator

I'd like to keep it as a "future feature" so the existence of the two curly quote features can be reviewed.

History:
Tools=>Unmatched=>Curly Quotes was added to GG2 first when other "unmatched" things were added - I don't think GG1 has an exact equivalent.
Tools=>Check Curly Quotes was added as a by-product of Tools=>Convert to Curly Quotes - again GG1 doesn't have an exact equivalent, since it inserts flag characters, such as "@" where it suspects there may be issues.

As suggested by @okrick above, possibly the best solution would be to remove Tools=>Unmatched=>Curly Quotes, but ensuring that any features it has, that are not already in Tools=>Check Curly Quotes, get transferred across.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
future feature New feature or request, but not core
Projects
None yet
Development

No branches or pull requests

3 participants