Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Search highlights #705

Open
okrick opened this issue Jan 28, 2025 · 4 comments
Open

Search highlights #705

okrick opened this issue Jan 28, 2025 · 4 comments
Assignees
Labels
core feature Required for basic PPing

Comments

@okrick
Copy link

okrick commented Jan 28, 2025

When using the Search dialog to search for a string, all occurrences of the string are highlighted faintly, in addition to the first occurrence being selected as previously. These faint highlights are removed when the user begins a new search or closes the Search dialog

The faint highlights remaining after replacing a search term are distracting. Can the highlights of the replacement also disappear immediately? Or at least allow Count to clear the highlighting.

Image

@okrick
Copy link
Author

okrick commented Jan 28, 2025

The highlighting remains distracting when I edit the found item instead of replacing it. This was particularly noticeable when working with proofreader notes, such as when I accepted their suggestion for correcting a typo.

@windymilla windymilla added the core feature Required for basic PPing label Jan 28, 2025
@srjfoo
Copy link
Member

srjfoo commented Jan 28, 2025

The replacement search term should be the only thing that has the faint highlighting -- what was your replacement search term? The faint highlighting of the previous search should disappear when a new search is started, or when the search dialog is closed.

@okrick
Copy link
Author

okrick commented Jan 28, 2025

The original search term was /\*((\n|.)+?)\*/. Despite replacing the selections, faint highlighting remains. I prefer to keep the Search & Replace dialog open while editing the found or replaced text, as closing it would require me to re-select the search and replace expressions from the drop-down menus, disrupting the workflow.

@tangledhelix tangledhelix self-assigned this Jan 29, 2025
@srjfoo
Copy link
Member

srjfoo commented Jan 29, 2025

Ah, I see ... the problem isn't with the search, it's that the replacement retains the highlighting?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
core feature Required for basic PPing
Projects
None yet
Development

No branches or pull requests

4 participants