Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix a couple of bookloupe nits #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a couple of bookloupe nits #710

wants to merge 1 commit into from
+11 −3

Conversation

windymilla
Copy link
Collaborator

  1. Don't report extra period if lowercase character after the period is just some inline markup
  2. Don't report Footnote 1: as standalone 1

Fixes #709

@windymilla windymilla requested a review from srjfoo January 28, 2025 20:54
@windymilla
Fix a couple of bookloupe nits
e72e988 
1. Don't report extra period if lowercase character after
the period is just some inline markup
2. Don't report  `Footnote 1:` as standalone 1

Fixes DistributedProofreaders#709
@srjfoo
Copy link
Member

srjfoo commented Jan 30, 2025

Should the following be being reported as standalone 1s?

<sc>IV</sc> 1 §§ 12, 13, <b>55</b>
Xen <i>anab</i> <sc>IV</sc> 1[**P3: 1/I ?] §§ 12-14.
<i>Catil 4 § 1 non fuit consilium

Test file, agricola CTF, no processing. It successfully ignores [Footnote: 1 ..., but also misses things that I expected to be identified. In fact, the file I'm using had nothing identified as a standalone 1.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@srjfoo srjfoo Awaiting requested review from srjfoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More bookloupe nits
2 participants
@windymilla @srjfoo