From 467c190c8f9450b443bf06bfdbe8da23bb411c90 Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Wed, 17 Jul 2019 12:20:50 +0100 Subject: [PATCH] Improve media method Avoid mutating the contents of the lists from the instance returned from `super()`, and instead use addition, [the recommended method of combining Media classes](https://docs.djangoproject.com/en/2.2/topics/forms/media/#combining-media-objects). --- django_admin_row_actions/admin.py | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/django_admin_row_actions/admin.py b/django_admin_row_actions/admin.py index 46b7a9a..fef5636 100644 --- a/django_admin_row_actions/admin.py +++ b/django_admin_row_actions/admin.py @@ -30,19 +30,11 @@ class AdminRowActionsMixin(object): @property def media(self): - css = super(AdminRowActionsMixin, self).media._css - css['all'] = css.get('all', []) - css['all'].extend(["css/jquery.dropdown.min.css"]) - - js = super(AdminRowActionsMixin, self).media._js - js.extend(["js/jquery.dropdown.min.js",]) - - media = forms.Media( - css=css, js=js + return super(AdminRowActionsMixin, self).media + forms.Media( + css={'all': ["css/jquery.dropdown.min.css"]}, + js=["js/jquery.dropdown.min.js"], ) - return media - def get_list_display(self, request): self._request = request list_display = super(AdminRowActionsMixin, self).get_list_display(request)