Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Space removed before "[" and after "]" #10

Closed
CharlieEtienne opened this issue May 28, 2018 · 2 comments
Closed

Space removed before "[" and after "]" #10

CharlieEtienne opened this issue May 28, 2018 · 2 comments
Labels

Comments

@CharlieEtienne
Copy link

CharlieEtienne commented May 28, 2018

Hi @DracotMolver , it's me again ;)

I experienced another bug:

.my-form[disabled=true] .my-input { cursor: not-allowed; }

is minified as:

.my-form[disabled=true].my-input{cursor:not-allowed;}

removing space between attribute value selector ([disabled=true]) and children class (.my-input)

As well as
.accordion [data-toggle='collapse']
is minified as
.accordion[data-toggle='collapse']

@CharlieEtienne CharlieEtienne changed the title Space removed after "]" Space removed before "[" and after "]" May 29, 2018
@CharlieEtienne
Copy link
Author

Maybe you should avoid to remove spaces from selectors, I don't know if there's some cases where it's useful...

@DracotMolver
Copy link
Owner

You are absolutely right. Even if i use the tag name, you will be working well on your normal css file. That means, you will do the next things:
.accordion [data-toggle='collapse']
span[data-toggle='collapse']
So, yes. There's no point to do it :). Thanks a lot @CharlieEtienne, I'll change the mock and the regex as soon as possible 👍

DracotMolver added a commit that referenced this issue Jun 1, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants