Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Centralize retry constants #255

Closed
johnbradley opened this issue Jul 1, 2019 · 0 comments · Fixed by #264
Closed

Centralize retry constants #255

johnbradley opened this issue Jul 1, 2019 · 0 comments · Fixed by #264
Assignees

Comments

@johnbradley
Copy link
Collaborator

I appreciate that these are constants at the top of the file and not buried as magic numbers, but I do think the number of retry constants has expanded enough to warrant a refactoring. As a follow up issue I'd suggest gathering these constants from the various files into a class where they could be grouped/structured/documented more easily.

Originally posted by @dleehr in #254

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant