Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adds retry logic to handle expired upload chunk urls #261

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Adds retry logic to handle expired upload chunk urls #261

merged 3 commits into from
Aug 6, 2019

Conversation

johnbradley
Copy link
Collaborator

Uses tenacity library to retry sending a chunk when 403 is received when sending to external store.

Fixes #260

NOTES:

  • There are many more retry places that would benefit from using tenacity. I will create an issue to handle that.
  • There is still an outstanding issue to centralize retry constants Centralize retry constants #255

@johnbradley
retry send external 403 status code
dcb4f07 
Adds changes to retry when we receive a 403 status code which
is potentially due to an expired url. This has been seen
after waiting out connection issues uploading a chunk.
@johnbradley
use tenacity to simplify retry changes
1c43e1d
@johnbradley
tests for retrying after 403
1a54bc1 
Added reraise=True to retry annotation so any raised exception
will not be wrapped in RetryError.
@johnbradley johnbradley requested a review from dleehr August 6, 2019 13:55
dleehr
dleehr approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@dleehr dleehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnbradley johnbradley merged commit 922be9f into master Aug 6, 2019
@johnbradley johnbradley deleted the 260-send-external-403-retry branch August 6, 2019 17:49
@johnbradley johnbradley mentioned this pull request Aug 6, 2019
Open
@dleehr dleehr mentioned this pull request Aug 12, 2019
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dleehr dleehr dleehr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

403 error sending file to S3 after connection errors
2 participants
@johnbradley @dleehr