Add cookie support for ios

[fzyzcjy]

Currently, this wonderful library only supports cookie in android, not ios. This pull request added support for ios. :)

[TimmNL]

Is it possible to merge this?

[n1ru4l]

@fzyzcjy Could you please rebase master?

[fzyzcjy]

@n1ru4l done!

[avertin]

+1 on getting cookie support for iOS

@fzyzcjy just curious, how do you get cookies to work for Android? Is there a setting?

[n1ru4l]

@avertin It looks like on Android this can be achieved by passing the Cookie header string to the source.headers property.

The Cookie header will then be automatically added:

react-native-fast-image/android/src/main/java/com/dylanvann/fastimage/FastImageViewConverter.java

Lines 66 to 75 in 47e36ed

	if (source.hasKey("headers")) {
	ReadableMap headersMap = source.getMap("headers");
	ReadableMapKeySetIterator iterator = headersMap.keySetIterator();
	LazyHeaders.Builder builder = new LazyHeaders.Builder();
	while (iterator.hasNextKey()) {
	String header = iterator.nextKey();
	String value = headersMap.getString(header);
	builder.addHeader(header, value);

Example:

const component = (
  <FastImage
    style={styles.image}
    source={{
      uri: "https://unsplash.it/400/400?image=1",
      headers: { Cookie: myCookieString },
      priority: FastImage.priority.normal
    }}
  />
);

[fzyzcjy]

@n1ru4l Hi, I am new to GitHub. It seems that you "approved these changes 13 days ago", but the state is still "open" instead of "merged". Therefore, I wonder what happens and what should I do?

[n1ru4l]

I have no access rights to this repository, therefore you will have to wait until the only maintainer (@DylanVann) merges it. On Dec 27, 2018 8:19 AM, "fzyzcjy" <notifications@github.com> wrote: @n1ru4l <https://github.com/n1ru4l> Hi, I am new to GitHub. It seems that you "approved these changes 13 days ago", but the state is still "open" instead of "merged". Therefore, I wonder what happens and what should I do? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#284 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANrH1zNbRtT2PSd0RAUTYqPehVxPXlTlks5u9HR3gaJpZM4Wqmw5> .

[fzyzcjy]

I have no access rights to this repository, therefore you will have to wait until the only maintainer (@DylanVann) merges it. On Dec 27, 2018 8:19 AM, "fzyzcjy" notifications@github.com wrote: @n1ru4l https://github.com/n1ru4l Hi, I am new to GitHub. It seems that you "approved these changes 13 days ago", but the state is still "open" instead of "merged". Therefore, I wonder what happens and what should I do? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#284 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ANrH1zNbRtT2PSd0RAUTYqPehVxPXlTlks5u9HR3gaJpZM4Wqmw5 .

OK thank you!

[steobrien]

Any chance we could get this merged in @DylanVann?

[fzyzcjy]

@steobrien +1

[steobrien]

@n1ru4l excuse the nag, but do you think we could get this merged soon?

[fzyzcjy]

P.S. I have done a merging from the master to this branch to resolve a very tiny conflict. Still waiting for collaborators to merge it to the master...

[n1ru4l]

@steobrien I still do not have any permissions on this repository and @DylanVann seems to only merge/check issues infrequently, which is highly unfortunate for such a widely used project.

Would be nice if he could consider moving it over to react-native-community and add some additional maintainers.

[fzyzcjy]

By the way, it has been one year since this PR has been created! How time flies!

[n1ru4l]

You can still use patch-package for applying this fix/feature

[fzyzcjy]

@n1ru4l Oh interesting!

[fzyzcjy]

Wow it merges!