Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enumeration issues #100

Open
VladimirAlexiev opened this issue Sep 26, 2024 · 0 comments
Open

Enumeration issues #100

VladimirAlexiev opened this issue Sep 26, 2024 · 0 comments
Assignees

Comments

@VladimirAlexiev
Copy link

  • You declare 3 enumerations but no values for them:
    `dprod:DataProductLifecycleStatus, dprod:InformationSensitivityClassification, dprod:SecuritySchemaType
    • That's not useful. Please collect at least an initial set of values. You cite 2 links, and there's also Wikidata, so you should be able to do it.
    • You can add a scopeNote that the enumeration is open, i.e. users are expected to add values.
    • For the last one you say dprod:securitySchemaType "# rdfs:range rdf:resource ; # better let user decide whether they want SecuritySchemaType class or own class or skos": that means the class SecuritySchemaType is doubly useless (the spec doesn't standardize members, and doesn't mandate its use)
  • Please consider using SKOS: it reduces the number of classes. To specify which skos:ConceptScheme is used by which prop, you can use the pattern adopted by ERA: they have an annotation property era:inSkosConceptScheme (Eg see LODE: improve name of inSkosConceptScheme Interoperable-data/ERA-Ontology-3.1.0#54)
  • (if you keep the current approach)
    • dprod:DataProductLifecycleStatusis declaredrdfs:subClassOfofdprod:Enumeration. But that should better be rdf:type, else Enumeration` will contain all kinds of values from various enumerations, which imho is not useful
    • Do that for the other enumerations as well
@rivettp rivettp self-assigned this Sep 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants